Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version of natural module that doesn't depend on webworker-threads #5

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Use version of natural module that doesn't depend on webworker-threads #5

merged 1 commit into from
Apr 12, 2018

Conversation

jasonrudolph
Copy link
Contributor

As a temporary solution until #4 is implemented, this pull request updates spelling-manager to depend on the last version of the natural module that didn't include the webworker-threads dependency.

The webworker-threads dependency was introduced in NaturalNode/natural@ba626e9, which first appears in 0.5.1. Therefore, this pull request declares a strict dependency on 0.5.0.


@dmoonfire: Would you be willing to merge this pull request and publish a new version of the spelling-manager module so that we can use it to resolve the issue described in atom/spell-check#67 (comment)?

Use the newest version of the natural module that does *not* include
thewebworker-threads module as a dependency.
@jasonrudolph
Copy link
Contributor Author

Hmm. I'm not sure why the Travis CI build is failing. All the tests pass locally:

$ git show
6d99a2f :arrow_down: [email protected] (Jason Rudolph, 2 hours ago)

$ npm install && npm test
npm notice created a lockfile as package-lock.json. You should commit this file.
updated 1 package in 2.515s
npm WARN lifecycle The node binary used for scripts is /Users/j/.nodenv/shims/node but npm is using /usr/local/Cellar/node/9.11.1/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.

> [email protected] pretest /Users/j/github/spelling-manager-js
> npm run build

npm WARN lifecycle The node binary used for scripts is /Users/j/.nodenv/shims/node but npm is using /usr/local/Cellar/node/9.11.1/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.

> [email protected] prebuild /Users/j/github/spelling-manager-js
> npm run lint

npm WARN lifecycle The node binary used for scripts is /Users/j/.nodenv/shims/node but npm is using /usr/local/Cellar/node/9.11.1/bin/node itself. Use the `--scripts-prepend-node-path` option to include the path for the node binary npm was executed with.

> [email protected] lint /Users/j/github/spelling-manager-js
> tslint --project src/


> [email protected] build /Users/j/github/spelling-manager-js
> tsc -p src


> [email protected] test /Users/j/github/spelling-manager-js
> mocha lib/spec/*-spec.js



  environment-spec.js
    ✓ verify test framework works

  tokenizer-spec.js
    ✓ an English sentence
    ✓ an English sentence with contraction
    ✓ a mostly English phrase with an accent
    ✓ a Japanese sentence


  5 passing (10ms)

@dmoonfire
Copy link
Owner

Oh, because I never set up Travis CI properly on this repo. I was trying to figure out a bug that was resolved differently.

@jasonrudolph jasonrudolph deleted the use-version-of-natural-without-webworker-threads branch April 12, 2018 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants