Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(filesystem): add a test for Windows UNC paths #423

Closed
wants to merge 3 commits into from
Closed

test(filesystem): add a test for Windows UNC paths #423

wants to merge 3 commits into from

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Apr 11, 2024 •
edited
Loading

@IlyaFaer IlyaFaer mentioned this pull request Apr 11, 2024
Merged
@IlyaFaer
Copy link
Contributor Author

@rudolfix, I tried to add UNC paths into the existing tests, but it doesn't work. UNC requires to keep the whole path of the file, without any attempts to make it relative, so it doesn't work with the existing tests.

@IlyaFaer IlyaFaer requested a review from rudolfix April 11, 2024 13:34
@rudolfix rudolfix closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolfix rudolfix Awaiting requested review from rudolfix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IlyaFaer @rudolfix