Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REST] Detailed error handler logging #383

Merged
merged 1 commit into from
Feb 29, 2024
Merged

[REST] Detailed error handler logging #383

merged 1 commit into from
Feb 29, 2024

Conversation

willi-mueller
Copy link
Collaborator

Tell us what you do here

  • improving, documenting, or customizing an existing source (please link an issue or describe below)

Relevant issue

issue #313

More PR info

Before:

2024-02-29 18:51:47,000|[INFO                 ]|5743|8123666432|dlt|client.py|make_request:62|Making GET request to https://testing.workable.com/spi/v3/candidate/138d8abe/offer with params={'limit': '100'}, json=None
2024-02-29 18:51:47,356|[INFO                 ]|5743|8123666432|dlt|client.py|paginate:120|Ignoring response and stopping pagination.

After:

2024-02-29 18:51:47,000|[INFO                 ]|5743|8123666432|dlt|client.py|make_request:62|Making GET request to https://testing.workable.com/spi/v3/candidate/138d8abe/offer with params={'limit': '100'}, json=None
2024-02-29 18:51:47,356|[INFO                 ]|5743|8123666432|dlt|client.py|paginate:120|Error 404. Ignoring response '{'result': 'NOT_FOUND', 'message': 'The requested resource is not found!'}' and stopping pagination.

@willi-mueller willi-mueller changed the base branch from master to enh/api_helper February 29, 2024 13:37
@burnash burnash merged commit f3ea829 into dlt-hub:enh/api_helper Feb 29, 2024
7 of 13 checks passed
@burnash
Copy link
Collaborator

burnash commented Feb 29, 2024

Great stuff, thanks @willi-mueller!

@willi-mueller willi-mueller deleted the detailed-error-handler-logging branch February 29, 2024 17:06
burnash added a commit that referenced this pull request Mar 22, 2024
@burnash @willi-mueller
@francescomucio @rudolfix @steinitzu
Implement a basic REST API client and a generic source (#313)
079a59f 
* REST API: support all authentication methods (#354)
* Generic API client: include parent fields in child resource (#355)
* Rest API: Ends pagination if next page path is not in response.json() (#361)
* Allow specification of SinglePagePaginator and refactors redundancy (#364)
* [REST Source] renames default_paginator argument to paginator (#367)
* [REST Source] completes renaming of default_paginator to paginator (#370)
* [REST source] test case for dependent resource (#371)
* [REST API source] adds function to check connection (#357)
* [REST Source] allow skipping http errors (#365)
* added the possibility to pass HTTPBasicAuth objects (#377)
* [REST] Detailed error handler logging (#383)
* [REST source] header_links can extract from responses without a records_path (#382)
* [REST source] fixes deprecation warning (#380)
* [REST CLIENT] alt response extractor (#396)
* Makes openapi friendly auth (#397)
* [REST CLIENT] yields data pages with requests context (#399)

---------

Co-authored-by: Anton Burnashev <[email protected]>
Co-authored-by: Willi Müller <[email protected]>
Co-authored-by: mucio <[email protected]>
Co-authored-by: rudolfix <[email protected]>
Co-authored-by: Steinthor Palsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willi-mueller @burnash