Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test all sources every night #315

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Conversation

AstrakhantsevaAA
Copy link
Collaborator

@AstrakhantsevaAA AstrakhantsevaAA commented Jan 2, 2024

Tell us what you do here

  • implementing verified source (please link a relevant issue labelled as verified source)
  • fixing a bug (please link a relevant bug report)
  • improving, documenting, customizing existing source (please link an issue or describe below)
  • anything else (please link an issue or describe below)

Relevant issue

issue #

More PR info

We need to check all our verified sources sometimes. We test them, but only when create or change them. They break silently all the time, and we find out about it from users or by accident.

Suggestion: we could have a nightly run, every night at 4am or so

burnash
burnash previously approved these changes Jan 4, 2024
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, @AstrakhantsevaAA

@rudolfix
Copy link
Contributor

@AstrakhantsevaAA run this only on duckdb on linux.

@burnash
Copy link
Collaborator

burnash commented Feb 26, 2024

@AstrakhantsevaAA one more thing: we need to exclude some tests from nightly tests. We can do that using custom pytest markers: https://docs.pytest.org/en/7.1.x/example/markers.html

@VioletM
Copy link
Contributor

VioletM commented Mar 4, 2024

@AstrakhantsevaAA maybe it makes sense to merge this even before all tests are up and running? This way we would see the stats on failing tests

@AstrakhantsevaAA
Copy link
Collaborator Author

@burnash I skip tests without stable test account here
@VioletM now we're waiting for only Kafka test, so I think now it makes sense to merge it.
@rudolfix OK

@AstrakhantsevaAA AstrakhantsevaAA merged commit d25b439 into master Mar 15, 2024
14 checks passed
@AstrakhantsevaAA AstrakhantsevaAA deleted the run_tests_every_night branch March 15, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants