Fix pagination issue in JSONResponseCursorPaginator with empty string cursor value
#2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
kang8
force-pushed
the
fix/2012-empty-string-for-pagination
branch
from
f63a102
to
ab7ea37
Compare
…ng cursor value Adjusts the `update_state()` method to set `_next_reference` to None when the cursor value extracted from the JSON response is an empty string, preventing unintended pagination requests. Fixed dlt-hub#2012
kang8
force-pushed
the
fix/2012-empty-string-for-pagination
branch
from
ab7ea37
to
3c7919e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusts the
update_state()method to set_next_referenceto Nonewhen the cursor value extracted from the JSON response is an empty
string, preventing unintended pagination requests.
Related Issues
JSONResponseCursorPaginator#2012Additional Context