Add open/closed range arguments for incremental #1991
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows configuring whether the incremental range is open or closed on both sides (start/end value).
Translates to changing the operators between
> | >=
/< | <=
in sql database source and in incremental filtering.Default is
start_range=closed
andend_range=open
, meaning the exact initial value is included and the exact end value is excluded.With
start_range=open
you getWHERE cursor > last_value
instead of>=
.With
end_range=closed
you get... cursor <= end_value
so non-overlapping chunks are still possible without the start_value deduplication logic.Related Issues
Additional Context