Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show full HTTP response on failure (Feat/1605) #1895

Open
wants to merge 5 commits into
base: devel
Choose a base branch
from

Conversation

willi-mueller
Copy link
Collaborator

@willi-mueller willi-mueller commented Sep 28, 2024

Description

This PR implements error logging of the full HTTP response on error when the dlt.sources.helpers.requests.Session is used.

Unless a custom session with different configuration is used, all HTTP responses with an error code 4xx will log an error.

This includes:

  1. the RESTClient
  2. each call made by the dlt.sources.rest_api

Related Issues

@willi-mueller willi-mueller linked an issue Sep 28, 2024 that may be closed by this pull request
Copy link

netlify bot commented Sep 28, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 26c87ad
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/670fc0c3e2df5f00086d002f

@willi-mueller willi-mueller changed the title Feat/1605 rest client show full response on failure show full HTTP response on failure (Feat/1605) Sep 28, 2024
@willi-mueller willi-mueller self-assigned this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

show full response when printing failed api calls
1 participant