logs warning if deduplication state is large #1877
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
willi-mueller
force-pushed
the
feat/1131-warn-large-deduplication-state
branch
from
cf80f0d
to
aeca74a
Compare
willi-mueller
changed the title
willi-mueller
changed the title
rudolfix
requested changes
Oct 8, 2024
|
|
||
| dedup_count = len(self._cached_state["unique_hashes"]) | ||
| DEDUP_WARNING_THRESHOLD = 200 | ||
| if dedup_count > DEDUP_WARNING_THRESHOLD: |
There was a problem hiding this comment.
this will flood user with messages. please compare the number of hashes before unique_hashes.update(transformer.unique_hashes) and after to see if threshold is crossed. so you display that only once
| if dedup_count > DEDUP_WARNING_THRESHOLD: | ||
| logger.warning( | ||
| f"There are {dedup_count} records to be deduplicated because" | ||
| f" they share the same primary key `{self.primary_key}`." |
There was a problem hiding this comment.
we need way better explanation here.
- primary key is not known sometimes, then we hash the content.
- the root cause is not primary key. it is low resolution of cursor column. ie it is on a day. use cursor column name here
| logger_spy = mocker.spy(dlt.common.logger, "warning") | ||
| p = dlt.pipeline(pipeline_name=uniq_id()) | ||
| p.extract(some_data(1)) | ||
| logger_spy.assert_any_call( |
There was a problem hiding this comment.
make sure it is displayed only once here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a first step towards resolving this issue: warns if the deduplication state grows over a large count of hashes of the primary key.
Related Issues
#1131