filesystem improvement and fixes #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# Conflicts: # tests/load/pipeline/test_filesystem_pipeline.py
# Conflicts: # tests/pipeline/utils.py
sh-rp
commented
Apr 24, 2024
| from fsspec import AbstractFileSystem | ||
|
|
||
|
|
||
| class FSClientBase(ABC): |
There was a problem hiding this comment.
this is to be debated, I find it very useful, but we can also make it private for now
sh-rp
commented
Apr 24, 2024
dlt/pipeline/pipeline.py
Outdated
| @@ -956,6 +958,21 @@ def sql_client(self, schema_name: str = None, credentials: Any = None) -> SqlCli | |||
| schema = self._get_schema_or_create(schema_name) | |||
| return self._sql_job_client(schema, credentials).sql_client | |||
|
|
|||
| def fs_client(self, schema_name: str = None, credentials: Any = None) -> FSClientBase: | |||
There was a problem hiding this comment.
more or less analog to sql_client
There was a problem hiding this comment.
I'd rename it to _fs_client until we discuss the exact interface.
sh-rp
changed the title
rudolfix
requested changes
Apr 24, 2024
dlt/pipeline/pipeline.py
Outdated
| @@ -956,6 +958,21 @@ def sql_client(self, schema_name: str = None, credentials: Any = None) -> SqlCli | |||
| schema = self._get_schema_or_create(schema_name) | |||
| return self._sql_job_client(schema, credentials).sql_client | |||
|
|
|||
| def fs_client(self, schema_name: str = None, credentials: Any = None) -> FSClientBase: | |||
There was a problem hiding this comment.
I'd rename it to _fs_client until we discuss the exact interface.
sh-rp
force-pushed
the
d#/load_utils_cleanup
branch
from
1abe6e0
to
535fe5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two bugs: