Add snowflake to application parameter to configuration #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rudolfix
requested changes
Apr 23, 2024
| @@ -49,6 +49,9 @@ def _read_private_key(private_key: str, password: Optional[str] = None) -> bytes | |||
| ) | |||
|
|
|||
|
|
|||
| snowflake_application_id = "dltHub_dlt" | |||
There was a problem hiding this comment.
is this the application id we picked for dlt? @VioletM ?
There was a problem hiding this comment.
I would make the var uppercase and import it into the test so we don't have any magic strings there
sultaniman
commented
Apr 23, 2024
rudolfix
requested changes
Apr 24, 2024
VioletM
reviewed
Apr 24, 2024
| @@ -39,11 +39,18 @@ username = "loader" | |||
| host = "kgiotue-wn98412" | |||
| warehouse = "COMPUTE_WH" | |||
| role = "DLT_LOADER_ROLE" | |||
| application = "dltHub_dlt" | |||
There was a problem hiding this comment.
I don't think we should put it here, because for most users it's not relevant and it just will be a default value.
There was a problem hiding this comment.
Got it I will remove this :)
VioletM
approved these changes
Apr 24, 2024
rudolfix
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow snowflake to track users using dlt we need to pass application parameter as query parameter.
If the value is set toskipwe do not include it (some users might want to disable). @rudolfix wdyt?Will use
""as a way to skip the addition ofapplicationparameter.Config example
Resolves: #1257