Segment Migration: Making Endpoint Configurable. #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
requested changes
Apr 17, 2024
|
@sh-rp I messed up the rebase. Need git support |
sh-rp
force-pushed
the
telemetry-segment-gcp
branch
from
5007f86
to
1772691
Compare
1. In init_segment() adding checks for env RUNTIME__TELEMETRY_ENDPOINT. 2. Update _SEGMENT_ENDPOINT based on env variable. Set default value if None provided with default write key. 3. Adjusting header based on endpoint.
sh-rp
force-pushed
the
telemetry-segment-gcp
branch
from
1772691
to
6eb5bc1
Compare
sh-rp
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing env variable
RUNTIME__TELEMETRY_ENDPOINTto overwrite default telemetry endpoint.Changes
RunConfigurationRUNTIME__TELEMETRY_ENDPOINT.