-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(filesystem): UNC paths are not supported #1209
Merged
Merged
Changes from 2 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
8e111c1
fix(filesystem): UNC paths are not supported
IlyaFaer 45d1d7b
small fix
IlyaFaer e39b8bc
use glob for UNC paths
IlyaFaer de82bb5
Merge branch 'devel' into windows_path_fix
IlyaFaer 7c465bc
add the third slash
IlyaFaer 6fee728
fix slahes
IlyaFaer f43a13a
fix if
IlyaFaer e813a3c
Merge branch 'devel' into windows_path_fix
rudolfix 95edfaf
less invasive switch to Python glob
rudolfix 50c6f2b
moves unc test to local so it runs on windows
rudolfix c045539
Merge branch 'devel' of https://github.com/dlt-hub/dlt into windows_p…
IlyaFaer 57a6b47
Merge branch 'windows_path_fix' of https://github.com/dlt-hub/dlt int…
IlyaFaer 2f1346c
review fixes
IlyaFaer 0b8e04e
test UNC path reading
IlyaFaer 7c1bdfb
add docs
IlyaFaer e7a893f
lint ignores
IlyaFaer fbcffbb
lint fix
IlyaFaer f111714
lint fix
IlyaFaer 7c0a918
excess ignore
IlyaFaer 5232ce6
lint fix
IlyaFaer 98b985f
Merge branch 'devel' into windows_path_fix
rudolfix e0ef3a9
adds utils to convert from file to local path to filesystem config
rudolfix d983976
offloads globbing to Python glob for locat paths, allows UNC and nati…
rudolfix 3810f80
allows the test file bucket to be relative path, fixes tests, adds se…
rudolfix 44cca36
bumps dev adlfs version up to have working glob
rudolfix 23aee6d
updates filesystem docs
rudolfix 556a256
fixes UNC to file uri
rudolfix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when do we get files starting with
//
? is this UNC path? please comment on thatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that's legacy, but I think we should consider it as equal to
\\
. Because... well, dealing with slash direction is very unpleasant for users.Anyway, I don't think it's needed anymore.
glob
seems to be handling fine all the possible cases.