Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable synchronization with history + give access to location in onError #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Enable synchronization with history + give access to location in onError #23

wants to merge 3 commits into from

Commits on Dec 7, 2017

  1. feat: Provide the location for which an error occurred in onError

    @dlmr
    dlmr committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    adae796 View commit details
    Browse the repository at this point in the history

  2. feat: New option, syncWithHistory, that will manage the history stack 

    Will default to true.

When false, and before, we would sometimes have situations that would be a little weird for end users. An example of this is when having a slow connection and clicking on first one link and then another before loading has completed. This would before result in two entires in the history stack, meaning that when we come to the page for our second link and then go back we would not go to the page we started at but rather the first link.

Also added in this feat is the possibility to reset the URL in the browser when aborting, something that will be enabled by default when syncWithHistory is true and no custom onAborted is defined.
    @dlmr
    dlmr committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    6431931 View commit details
    Browse the repository at this point in the history

  3. docs: Updated the simple example to showcase the new syncWithHistory

    @dlmr
    dlmr committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    912f0cd View commit details
    Browse the repository at this point in the history