Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hash function from the MD5 to the SHA1 #57

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Change hash function from the MD5 to the SHA1 #57

merged 4 commits into from
Nov 15, 2024
+43 −22

Conversation

Hrom131
Copy link
Member

@Hrom131 Hrom131 commented Nov 15, 2024

  • Since this PR suggests a bug fix, the relevant tests have been added.
  • Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
  • This PR is just a minor change, like a typo fix.

@Hrom131 Hrom131 self-assigned this Nov 15, 2024
@Hrom131 Hrom131 changed the title Change hash function from the MD5 to the SHA256 Change hash function from the MD5 to the SHA1 Nov 15, 2024
Arvolear
Arvolear approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit 20e50c3 into master Nov 15, 2024
2 checks passed
@Arvolear Arvolear deleted the fix/hash_function branch November 15, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arvolear Arvolear Arvolear approved these changes

Assignees

@Hrom131 Hrom131

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hrom131 @Arvolear @1KitCat1