-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #88 -- Enhanced ESLint Configuration and improved Code Quality #116
Conversation
This is still giving conflict warnings. I need to check it again. |
import { API_ENDPOINTS } from '@/constants' | ||
import { EventsResponse } from '@/types' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add rule to disallow imports from @/*
like it should not have /
Is this PR ready for review ? @SureshPradhana |
The rule requires camelCase for general naming, but React components use PascalCase, which creates a conflict. For components, PascalCase should be used, while camelCase applies to other names. Additionally, there are some ESLint warnings that need to be fixed before this is ready for review. A custom ESLint plugin is also needed to restrict imports from |
@Saurabhsharma884 updated the ESLint rules to avoid using @/*, and the rules for camelCase and PascalCase are conflicting due to React component naming conventions. The rules are either camelCase or PascalCase for variables and functions |
@SureshPradhana Can you please rebase/resolve conflicts in this branch ? |
0473d59
to
a9f7a0a
Compare
@Saurabhsharma884 updated |
Sorry, missed this. Can you please update again? |
@Saurabhsharma884 This might take some time to complete, but I'm working on it. |
Sure, thanks for that but there has been a major upgrade to eslint v9 which supports flat config only but there has been multiple issues floating on github regarding its compatibility with plugins so we should wait for sometime and let those issues get resolved. we can upgrade to eslint v9 after that. |
Changes are picked #234. Hence, closing this MR. Thanks @SureshPradhana |
Closes #88
Summary
Enhance ESLint rules to align with coding standards and improve code quality.
Changes
.eslintrc.json
.type
prefixes for importing types.68a0066
,5168fb4
,0a6f8ce
).Type of change
Flags
Demo
How has this been tested?
Author Checklist
main
fromfork:branchname
Additional context