Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CSS classes and HTML skeleton for announcement banner. #1302

Merged
merged 9 commits into from
Nov 2, 2023

Conversation

Maniktherana
Copy link
Contributor

The billboard's styles can now be implemented with the .banner-container and .banner classes:

<div id="billboard" class=".banner-container">{% block billboard %}
    <div class="banner">
        ...

Resolve #1035

@pauloxnet
Copy link
Member

@Maniktherana thanks for your contribution, can you provide a screenshot of your change in dark and light mode ?

@Maniktherana
Copy link
Contributor Author

Maniktherana commented Jan 23, 2023

@pauloxnet Sure thing, here's what it looks like when I apply them to a banner from a previous commit:

Screenshot 2023-01-23 at 3 53 52 PM

Screenshot 2023-01-23 at 3 54 06 PM

Currently, there's no banner so based on previous commits this is how it can be implemented:

Screenshot 2023-01-23 at 3 55 02 PM

@Maniktherana Maniktherana changed the title Css banner feat: add css classes for banner styling Jan 23, 2023
@pauloxnet
Copy link
Member

Thanks! I'd like to hear the opinion of @carltongibson who opened the issue #1035

Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Maniktherana — this looks about right.

Just one comment...

djangoproject/templates/base.html Outdated Show resolved Hide resolved
@carltongibson carltongibson changed the title feat: add css classes for banner styling Added css classes and HTML skeleton for announcement banner. Jan 24, 2023
@carltongibson carltongibson changed the title Added css classes and HTML skeleton for announcement banner. Added CSS classes and HTML skeleton for announcement banner. Jan 24, 2023
@Maniktherana
Copy link
Contributor Author

@carltongibson how does this look?

@Maniktherana
Copy link
Contributor Author

@carltongibson I got rid of the inner div wrapping the p block as it didn't seem to be accomplishing anything.

djangoproject/scss/_style.scss Outdated Show resolved Hide resolved
djangoproject/templates/base.html Outdated Show resolved Hide resolved
@Maniktherana
Copy link
Contributor Author

Maniktherana commented Jan 24, 2023

@carltongibson I just realized that the styles don't make sense according to the screenshots I sent earlier. They should look like this:
Screenshot 2023-01-24 at 7 30 05 PM
Screenshot 2023-01-24 at 7 30 15 PM
In light of this, I'll be keeping the nested div and .banner-container class

@sabderemane
Copy link
Member

@Maniktherana are you still working on this ?

@sabderemane
Copy link
Member

I update the current branch and have done some edition on style and HTML comment.
This is the result with the current banner with light and dark mode :
Capture d’écran 2023-10-07 à 23 30 24
Capture d’écran 2023-10-07 à 23 30 32

@django/djangoproject-com-maintainters should be merged after the remove of the banner for Django Developer Survey

Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sabderemane — this looks good to me. If you're happy please do proceed!

Thanks! 🎁

@sabderemane sabderemane merged commit 80eae28 into django:main Nov 2, 2023
2 checks passed
@sabderemane
Copy link
Member

Thank you for your help to contribute to this @Maniktherana 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Create CSS for Banner styling.
4 participants