-
-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CSS classes and HTML skeleton for announcement banner. #1302
Conversation
@Maniktherana thanks for your contribution, can you provide a screenshot of your change in dark and light mode ? |
@pauloxnet Sure thing, here's what it looks like when I apply them to a banner from a previous commit: Currently, there's no banner so based on previous commits this is how it can be implemented: |
Thanks! I'd like to hear the opinion of @carltongibson who opened the issue #1035 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Maniktherana — this looks about right.
Just one comment...
@carltongibson how does this look? |
@carltongibson I got rid of the inner div wrapping the p block as it didn't seem to be accomplishing anything. |
@carltongibson I just realized that the styles don't make sense according to the screenshots I sent earlier. They should look like this: |
@Maniktherana are you still working on this ? |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ba58368
to
a01d942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sabderemane — this looks good to me. If you're happy please do proceed!
Thanks! 🎁
Thank you for your help to contribute to this @Maniktherana 🎉 |
The billboard's styles can now be implemented with the
.banner-container
and.banner
classes:Resolve #1035