Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DI-2715] Implementing send notification task for account app #93

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[DI-2715] Implementing send notification task for account app #93

wants to merge 3 commits into from

Conversation

denys-chura
Copy link
Collaborator

@denys-chura denys-chura commented Oct 31, 2024 •
edited
Loading

image

@denys-chura denys-chura self-assigned this Oct 31, 2024
denys-chura
denys-chura commented Oct 31, 2024
View reviewed changes
...utter.project_slug }}/api/{{ cookiecutter.project_slug }}/apps/accounts/services/password.py
Comment on lines -49 to +50
cls._send_notification(user.pk, context)
cls._send_notification(user.email, context)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it make more sense to pass email insteead of pk here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulya bulya Awaiting requested review from bulya

@SergeyKubrak SergeyKubrak Awaiting requested review from SergeyKubrak

@alexryabtsev alexryabtsev Awaiting requested review from alexryabtsev

At least 1 approving review is required to merge this pull request.

Assignees

@denys-chura denys-chura

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@denys-chura