Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ§‘β€πŸ’» SHA256 Splitting Demo (rebased) #8

Merged
merged 18 commits into from
Sep 30, 2024

Conversation

Velnbur
Copy link
Collaborator

@Velnbur Velnbur commented Sep 30, 2024

Note

This is a rebased version of #7.

Objective

To test the splitting functionality, we import the SHA256 function implementation from BitVM and check the splitting algorithm.

Added

  • SplitType, allowing to specify how the chunk should be processed (cut by the number of instructions or bytes).
  • SHA256 demo.

@ZamDimon ZamDimon changed the title Sha256 demo rebased πŸ§‘β€πŸ’» Sha256 Demo (rebased) Sep 30, 2024
@ZamDimon ZamDimon assigned ZamDimon and Velnbur and unassigned ZamDimon Sep 30, 2024
@ZamDimon ZamDimon self-requested a review September 30, 2024 18:21
@ZamDimon ZamDimon added the feature New feature or request label Sep 30, 2024
@ZamDimon ZamDimon changed the title πŸ§‘β€πŸ’» Sha256 Demo (rebased) πŸ§‘β€πŸ’» SHA256 Splitting Demo (rebased) Sep 30, 2024
Copy link
Collaborator

@ZamDimon ZamDimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (since I am the author of this PR lol)

@Velnbur Velnbur merged commit 3335f41 into main Sep 30, 2024
4 checks passed
@Velnbur Velnbur deleted the sha256-demo-rebased branch September 30, 2024 18:51
ZamDimon added a commit that referenced this pull request Oct 4, 2024
> [!NOTE]
> This is a rebased version of #7.

# Objective

To test the splitting functionality, we import the SHA256 function
implementation from [BitVM](https://github.com/BitVM/BitVM) and check
the splitting algorithm.

## Added
- `SplitType`, allowing to specify how the chunk should be processed
(cut by the number of instructions or bytes).
- SHA256 demo.

---------

Co-authored-by: ZamDimon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants