Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👩‍💻 Add CI check if code is formatted #25

Merged
merged 3 commits into from
Oct 28, 2024
Merged

👩‍💻 Add CI check if code is formatted #25

merged 3 commits into from
Oct 28, 2024

Conversation

Velnbur
Copy link
Collaborator

@Velnbur Velnbur commented Oct 28, 2024 •
edited
Loading

🔍 Objective

Currently, we don't check if the code in the repo is formatted.

🆕 Added

New CI job that does that.

✅ Checklist

  • PR title corresponds to the body of changes.
  • PR has a proper label, assignee, and reviewers.
  • Tests that cover the changes are added (if needed).
  • Documentation (README files, paper) and Code Comments are updated accordingly.
  • Code is formatted, all tests pass, and CI shows no errors.

@Velnbur Velnbur added the feature New feature or request label Oct 28, 2024
@Velnbur Velnbur requested a review from ZamDimon October 28, 2024 07:59
@Velnbur Velnbur self-assigned this Oct 28, 2024
@ZamDimon ZamDimon changed the title Add CI check if code is formatted 👩‍💻 Add CI check if code is formatted Oct 28, 2024
ZamDimon
ZamDimon approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@ZamDimon ZamDimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Always wanted by fmt to be checked :)

@Velnbur Velnbur merged commit 042f601 into main Oct 28, 2024
5 checks passed
@Velnbur Velnbur deleted the ci-fmt-check branch October 28, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZamDimon ZamDimon ZamDimon approved these changes

Assignees

@Velnbur Velnbur

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velnbur @ZamDimon