-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing #639: print stacktrace in logs #658
Addressing #639: print stacktrace in logs #658
Conversation
zainab-ali seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Henry Parker seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Edit: committer and author were different in git, but they're both me, so I changed the commit to reflect that and the second comment can be ignored. I can make a new PR if necessary |
Hey @henryxparker, sorry for putting some eyes on this only now, things were crazy at work when you raised the PR and I totally forgot to go back to it, apologies. Anyway, the best location to add tests for this feature would probably be here. Chances are you should probably handcraft a stacktrace to make it easy to compare results and expectations |
Co-authored-by: Sam Pillsworth <[email protected]>
Add initial Code of Conduct
Remove the intellij runner, docs, and site link
tests(catsJVM): fix paths in Cats JVM tests
Fix CI pipeline
Migrate build to sbt-typelevel
Understandably the IntelliJ section was removed. This portion of the documentation is still very useful, especially for people who are used to being able to hit the play button on individual tests. The old intellij sections has been moved to "Frequently Asked Questions".
Fix organization and artifact names
Adds `.only` and `.ignore` documentation.
Sorry for the long wait. I was laid off for a while and totally forgot that I had made this PR. |
@henryxparker thanks for taking the time to come back to this PR ! However, weaver is in the process of being moved to the typelevel organisation, and though I cannot attest to when exactly the move will conclude, it's quite unlikely that I'll issue another release of weaver under the disneystreaming organisation. If it's not too much to ask, I would suggest moving your PR over there. |
Oh sweet, I'll add it there. Could you add something to the README to indicate this move? |
This is a quick and dirty fix for the weaver.Log not printing stack traces.
I didn't see any tests for the core module so I didn't write any.
Any feedback appreciated