Skip to content

Commit

Permalink
Go back to 1.43.0, no need to force a new version on users
Browse files Browse the repository at this point in the history
  • Loading branch information
daddykotex committed Aug 17, 2022
1 parent dc48741 commit 34222b1
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion it/runTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ async function main() {

// Download VS Code, unzip it and run the integration test
await runTests({
version: "1.66.0", // force this version to avoid https://github.com/microsoft/vscode/issues/148975
// we use 1.53.0 rather than 1.43.0 because it's the first one
// available to be downloaded. Latest also has the following issue:
//https://github.com/microsoft/vscode/issues/148975
version: "1.53.0",
extensionDevelopmentPath,
extensionTestsPath,
});
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"extension.vsix"
],
"engines": {
"vscode": "^1.66.0"
"vscode": "^1.43.0"
},
"dependencies": {
"follow-redirects": "^1.14.9",
Expand All @@ -98,7 +98,7 @@
"@types/follow-redirects": "^1.14.1",
"@types/jest": "^27.4.0",
"@types/node": "^17.0.21",
"@types/vscode": "^1.66.0",
"@types/vscode": "^1.43.0",
"@typescript-eslint/parser": "^2.3.0",
"@vscode/test-electron": "^2.1.5",
"eslint": "^8.10.0",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 34222b1

Please sign in to comment.