Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include field modifiers in collision avoidance #1593

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Sep 26, 2024

In #1301, we forgot to apply collision avoidance on field modifiers (which include the TypedNode for the field's default value). This would result in incorrectly rendering an unchanged type name in default values, which could result in e.g. a Scala keyword, or a lowercase reference to a shape that gets rendered as uppercase (as reported in #1592).

Closes #1592

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

@kubukoz kubukoz changed the title Reproduce #1592 Include field modifiers in collision avoidance Sep 26, 2024
@Baccata Baccata merged commit c8b5a04 into series/0.18 Sep 30, 2024
9 checks passed
@Baccata Baccata deleted the fix-1592 branch September 30, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants