Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate NoStackTrace error types #1104

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Generate NoStackTrace error types #1104

merged 5 commits into from
Jul 25, 2023

Conversation

yisraelU
Copy link
Contributor

@yisraelU yisraelU commented Jul 20, 2023 •
edited
Loading

Not sure if this is a great idea or too specific of a Scala idiom . Inspired by #1070

  • Adds a smithy trait @noStackTrace to annotate structures that are annotated with the @error trait.
  • This influences the codegen that error data types extend scala.util.control.NoStackTrace instead of directly Throwable

@yisraelU yisraelU marked this pull request as draft July 20, 2023 01:25
@yisraelU yisraelU changed the title add nostacktrace meta trait Generate NoStackTrace error types Jul 20, 2023
@yisraelU yisraelU marked this pull request as ready for review July 20, 2023 04:36
@Baccata
Copy link
Contributor

Baccata commented Jul 24, 2023

@yisraelU I'm cool with the idea. Can you sync with the latest 0.18 and we'll merge it

@Baccata Baccata merged commit 0d5c545 into disneystreaming:series/0.18 Jul 25, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baccata Baccata Baccata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yisraelU @Baccata