Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline publishing plugin and increase timeouts #178

Merged
merged 2 commits into from
Aug 4, 2024
Merged

Conversation

lewisjkl
Copy link
Contributor

@lewisjkl lewisjkl commented Aug 2, 2024

We are getting timed out connections (seemingly) when publishing to sonatype, inlining the plugin (at least for now) will let us control the timeout values as they are hard coded.

@lewisjkl
Copy link
Contributor Author

lewisjkl commented Aug 2, 2024

Not sure if this is a valid test, but this change does seem to make it so snapshots can be published https://github.com/disneystreaming/alloy/actions/runs/10222750548/job/28287914273 so I assume it will work for regular versions as well. @Baccata we can go forward with this if you think it looks good (not positive I did it in the simplest way mill-wise so I'd like your thoughts)

@lewisjkl lewisjkl requested a review from Baccata August 2, 2024 22:28
Copy link
Contributor

@Baccata Baccata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's roll with it

@Baccata Baccata merged commit 5902dc8 into main Aug 4, 2024
4 checks passed
@Baccata Baccata deleted the inline-publish-plugin branch August 4, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants