Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

chore: update examples for v13 #174

Closed
wants to merge 4 commits into from
Closed

chore: update examples for v13 #174

wants to merge 4 commits into from

Conversation

Fyko
Copy link
Contributor

@Fyko Fyko commented Aug 9, 2021

Please describe the changes this PR makes and why it should be merged:
This PR updates examples for Discord.js v13. Additionally, it fixes a documentation error.

Closes #170.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #174 (d3658c7) into main (687e0e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   73.84%   73.84%           
=======================================
  Files          21       21           
  Lines         906      906           
  Branches      221      227    +6     
=======================================
  Hits          669      669           
  Misses        235      235           
  Partials        2        2           
Impacted Files Coverage Δ
src/joinVoiceChannel.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687e0e8...d3658c7. Read the comment docs.

Copy link
Contributor

@iim-ayush iim-ayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some check mechanism instead of setting guild commands again and again.

const app = await client.application?.fetch();
const devGuild = await client.guilds.fetch(deployment_guild_id).catch(() => null);
if (app && devGuild) {
await devGuild.commands.set([
Copy link
Contributor

@iim-ayush iim-ayush Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have some check if the commands are already present in the guild before setting commands again and again at every start of bot.

@Jiralite Jiralite mentioned this pull request Aug 25, 2021
@amishshah
Copy link
Member

@Fyko could you remove the unnecessary intent mentioned above and also move command deployment to its own script that can be run separately?

@imranbarbhuiya
Copy link

Why it's not getting merged?

@Fyko Fyko closed this by deleting the head repository Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update discord.js examples
5 participants