Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create guide for seeking audio resource #1483

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

Fyphen1223
Copy link

@Fyphen1223 Fyphen1223 commented Jun 16, 2023

Create a guide for seeking audio resources.

Please describe the changes this PR makes and why it should be merged:
Explain how to seek audio resources with raw discord.js and @discordjs/voice
Many questions about seeking are posted on discord.js guild, and there's no guide about seeking. So I created this.

@Fyphen1223
Copy link
Author

ESLint is kinda...

@Fyphen1223
Copy link
Author

I'm afraid but could you run ESLint one more time? I have fixed all of the error and warning.

@Fyphen1223
Copy link
Author

Thanks bro

guide/voice/seeking.md Outdated Show resolved Hide resolved
guide/voice/seeking.md Outdated Show resolved Hide resolved
guide/voice/seeking.md Outdated Show resolved Hide resolved
guide/voice/seeking.md Outdated Show resolved Hide resolved
guide/voice/seeking.md Show resolved Hide resolved
guide/voice/seeking.md Outdated Show resolved Hide resolved
guide/voice/seeking.md Outdated Show resolved Hide resolved
guide/voice/seeking.md Outdated Show resolved Hide resolved
guide/voice/seeking.md Outdated Show resolved Hide resolved
guide/voice/seeking.md Outdated Show resolved Hide resolved
Fyphen1223 and others added 2 commits August 1, 2023 10:41
@Fyphen1223
Copy link
Author

k it seems like I've fixed all reviews you sent

@Fyphen1223
Copy link
Author

so I have to wait until ESLint approval and merge

@Fyphen1223
Copy link
Author

Hey I'm really sorry but could you run ESLint one more time

@Fyphen1223
Copy link
Author

Sorry could you re-run ESLint check

(Why ESLint says readability is unnecessary)

@Fyphen1223
Copy link
Author

Thank you so much for running so many ESLint check

@almostSouji almostSouji added the meta: voice Related to the voice lib guide label Nov 24, 2023
@ducktrshessami
Copy link

Personally I'd be against having this as its own article. A more general Popular Topics > prism-media guide would make sense. On its own, this just feels like a guide for FFmpeg; one that already exists at that. This and "Decoding an Opus stream" as examples would cover the only two features of prism-media that realistically would need to be implemented separately from @discordjs/voice as of right now. As a side note, it could also be mentioned that @discordjs/voice already depends on prism-media and presumably shouldn't be installed separately for the same reason one shouldn't install the other subpackages separately.

@Fyphen1223
Copy link
Author

Fyphen1223 commented Dec 8, 2023

@ducktrshessami Yeah, that's true enough, but honestly, this will eventually fit in voice section. Because adding content like this in popular topics does not related to discord.js directly. Adding this in voice section (because u know how do you use these things in other part of discord.js bot developing) will be better in my opinion.

Copy link

@ducktrshessami ducktrshessami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't referring to the "Popular Topics" section of the main guide. I agree that a guide about prism-media is more relevant in the Voice guide. I am simply opposed to this as a standalone article. A new "Popular Topics" section can be added since this isn't directly related to @discordjs/voice. If you do agree I'd definitely like to see this rewritten before being merged.

@Fyphen1223
Copy link
Author

I wasn't referring to the "Popular Topics" section of the main guide. I agree that a guide about prism-media is more relevant in the Voice guide. I am simply opposed to this as a standalone article. A new "Popular Topics" section can be added since this isn't directly related to @discordjs/voice. If you do agree I'd definitely like to see this rewritten before being merged.

I see I got it. So you mean, like creating new 'Popular Topics' in voice MD and referring this kind of articles in it?

@Jiralite Jiralite requested review from ducktrshessami and vladfrangu and removed request for ducktrshessami September 7, 2024 18:30
Copy link

@ducktrshessami ducktrshessami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see I got it. So you mean, like creating new 'Popular Topics' in voice MD and referring this kind of articles in it?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: voice Related to the voice lib guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants