Remove commands we don't want to support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthova
force-pushed
the
matthova/remove-old-commands
branch
from
6998928
to
6eb9aa5
Compare
matthova
force-pushed
the
matthova/remove-old-commands
branch
from
6eb9aa5
to
7cf96c6
Compare
infinitestory
approved these changes
Mar 5, 2024
docs/common-patterns/layout-mode.md
Outdated
| export default function LayoutMode() { | ||
| const handleLayoutModeUpdate = React.useCallback((update: {layout_mode: number}) => { | ||
| const handleLayoutModeUpdate = React.useCallback((update: EventPayloadData<"ACTIVITY_LAYOUT_MODE_UPDATE">) => { |
There was a problem hiding this comment.
Prefer the const for the action name Events.ACTIVITY_LAYOUT_MODE_UPDATE, here and below
There was a problem hiding this comment.
We would need to import as a type, i.e.
import type {Events, EventPayloadData} from '@discord/embedded-app-sdk';
type Foo = EventPayloadData<Events.ACTIVITY_INSTANCE_PARTICIPANTS_UPDATE>['participants']As-is we get autocomplete and it will throw an error if it's not a valid string. Do we feel strongly about enforcing that style? I'm (strong opinion, loosely held) pro using strings because of the smaller size and less footguns around importing an enum
There was a problem hiding this comment.
Per convo, this doc is migrated to the main docs site, but we can explore updating our patterns in the docs outside the scope of this PR
matthova
force-pushed
the
matthova/remove-old-commands
branch
from
7cf96c6
to
cdb26cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.