-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add sso_auth parameter #45
Conversation
ab34d7e
to
0018c81
Compare
- Update the Pritunl Docker image version to `1.32.3602.80` Signed-off-by: Quentin BERTRAND <[email protected]>
Hello @disc 👋 |
Hey @QuentinBtd, i appreciate your contribution, but I think it won't work without configuration of SSO settings for the whole pritunl instance (see the attached screenshot). I started to work on the instance settings some time ago here () but haven't completed it yet. |
Do you think Pritunl will return an error if the provider send a JSON with I could try it with an instance where SSO is not configured 😃 |
That's exactly what I want to do 👍 The SSO configuration is already present on my instance. My servers are provisioned via Terraform but I have to manually check |
@@ -336,6 +336,12 @@ func resourceServer() *schema.Resource { | |||
Optional: true, | |||
Description: "Show server debugging information in output.", | |||
}, | |||
"sso_auth": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test case for a new option
For
Got you, lets add a test for the new option and fix small issues that I left. |
- Modify the `SsoAuth` field to allow it to be omitted in the JSON representation Signed-off-by: Quentin BERTRAND <[email protected]>
@QuentinBtd I'm going to close this PR as a duplicate, because I've just merged another PR with a support of the same option sso_auth #48 |
No problem |
Why ?
sso_auth
parameter exists in Priutnl servers.When set at
true
, it will require client to authenticate with single sign-on provider on each connection using web browser.It could be usefull to have it. (And I need it, of course)
How ?
Adding it in provider.
Bonus
Update pritunl docker image version.