feat(matching-context): expose list of domains in API #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutangar
force-pushed
the
expose-domains
branch
from
4897c4c
to
a417211
Compare
Exposes the list of domains on which a matching context is applicable. It also exposes the *path* part of the regexp uses in mathching context... Some current and previous vocabulary seems dodgy... maybe a `DomainName` should be renamed to `Domain` so we can use `domainName` only for the actual string version of the domain name... Also `urlPathRegex` is not truly a *path* __regex__ since the user can choose to match all domains... is that still supposed to be possible? > fix #446
lutangar
force-pushed
the
expose-domains
branch
from
a417211
to
6f24b8d
Compare
JalilArfaoui
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the list of domains on which a matching context is applicable. It also exposes the path part of the regexp uses in mathching context...
Some current and previous vocabulary seems dodgy... maybe a
DomainNameshould be renamed toDomainso we can usedomainNameonly for the actual string version of the domain name...Also
urlPathRegexis not truly a path regex since the user can choose to match all domains... is that still supposed to be possible?