Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamping the Backend UI for matching-context : create product targeted fields #448

Closed
zhinu opened this issue Sep 13, 2021 · 4 comments · Fixed by #455
Closed

Revamping the Backend UI for matching-context : create product targeted fields #448

zhinu opened this issue Sep 13, 2021 · 4 comments · Fixed by #455
Assignees

Comments

@zhinu
Copy link
Collaborator

zhinu commented Sep 13, 2021

Stakes

Transitioning from regex and xpath to nocode

Context

Today, the matching context has the following fields
Capture d’écran 2021-09-13 à 13 01 06

The fields Regex target the url whereas xpath target the Document Object Model (DOM). Those two fields, need a special expertise to be used, hence not user friendly

Wished evolution

Web pages often have a similar structure :

Product

  • Title Name
  • Category
  • Description
  • Price

Offer

  • Location

The previous parts should be targetable directly from the backend.

For Title, Category, and Description the possibility would be to have the following options logical connectors

AND OR EXCEPT
i.e.
(term1 and term2) or term3 except term4

For Price, the following possibility should be to have the following mathematical functions

lower than <, greater than, lower than or equal to <=, greater than or equal to >=

Ie.
lower than or equal to <= number 1 and greater than > number 2

For the last part location, a more intuitive way would be to select cities or regions directly from a dropdown list or a map.

@lutangar
Copy link
Member

@MaartenLMEM MaartenLMEM changed the title Revamping the Backend UI for matching-context (transitioning from regex and xpath to nocode) Revamping the Backend UI for matching-context : create product targeted fields Sep 15, 2021
@MaartenLMEM MaartenLMEM assigned lutangar and unassigned MaartenLMEM Sep 20, 2021
lutangar added a commit that referenced this issue Sep 22, 2021
Uses part of the https://schema.org vocabulary.
Make use of the api platform schema generator to bootstrap entities.

> resolves #448
@MaartenLMEM
Copy link
Contributor

MaartenLMEM commented Sep 23, 2021

@lutangar I just commented the related issue on mobile repo : dis-moi/mobile#239 (comment)
Afterwards, don't you think the BO/API should do this work ?
And clients such as mobile app would make his own "advanced" translations only if BO is less appropriate to make it (for efficiency reasons, privacy reasons or others) ?

@MaartenLMEM
Copy link
Contributor

MaartenLMEM commented Sep 26, 2021

Ok discussed friday, there a misunderstanding.
Let's review this and we ll make other fields later

JalilArfaoui pushed a commit that referenced this issue Sep 28, 2021
Uses part of the https://schema.org vocabulary.
Make use of the api platform schema generator to bootstrap entities.

> resolves #448
@MaartenLMEM
Copy link
Contributor

MaartenLMEM commented Sep 28, 2021

Tested on BO. It s ok... But during next step, it s important to discuss about how it will be used by extensions et mobile apps.

See for example this notice in staging
=> An important rule will habe to add on extension part is the following : If there is product name filled, ignore this matching context. Otherwise it will match on each product page of Amazon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants