Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getVariantsAllProducts, getProducts, Product (not from order), ImageResource #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MagicStino
Copy link

@MagicStino MagicStino commented Feb 7, 2023

Added a function to retrieve all existing product variants from ecom shop (not from order).
Added a function to retrieve all products for ecom shop, added simple Product Type and for that added ImageResource

@bramski
Copy link
Contributor

bramski commented Feb 7, 2023

You've butchered the package-lock. Please revert it. Types file looks wrong, types should end with a semicolon.
Please make a description for your PR.

@MagicStino MagicStino marked this pull request as ready for review February 7, 2023 01:56
@MagicStino
Copy link
Author

You've butchered the package-lock. Please revert it. Types file looks wrong, types should end with a semicolon. Please make a description for your PR.

Thanks, I'm a novice in node/npm/git I tried to follow up your instructions. Hope I did wright. Should I exclude package-lock.json in the future?

@bramski
Copy link
Contributor

bramski commented Feb 7, 2023

Just depends on if you have changes. You don't so the package-lock shouldn't change.
Your types are still wrong. Should be semicolons and not commas.

@MagicStino
Copy link
Author

MagicStino commented Feb 7, 2023

fixed, must had being tired. compiled fine though ;) And thanks for feedback on package-lock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants