Fix panics introduced in move from ReadFunc to ReadContextFunc (#506)

* resourceDigitalOceanCDNRead: return nil on success (Closes: #505). * resourceDigitalOceanAppRead: return nil on success.
digitalocean · Oct 22, 2020 · 295deb7 · 295deb7
1 parent a1f8c4d
commit 295deb7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/digitalocean/resource_digitalocean_app.go b/digitalocean/resource_digitalocean_app.go
@@ -3,10 +3,11 @@ package digitalocean
 import (
 	"context"
 	"fmt"
-	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"log"
 	"time"
 
+	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
+
 	"github.com/digitalocean/godo"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 )
@@ -115,7 +116,7 @@ func resourceDigitalOceanAppRead(ctx context.Context, d *schema.ResourceData, me
 		return diag.Errorf("[DEBUG] Error setting app spec: %#v", err)
 	}
 
-	return diag.FromErr(err)
+	return nil
 }
 
 func resourceDigitalOceanAppUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {

diff --git a/digitalocean/resource_digitalocean_cdn.go b/digitalocean/resource_digitalocean_cdn.go
@@ -212,7 +212,7 @@ func resourceDigitalOceanCDNRead(ctx context.Context, d *schema.ResourceData, me
 		d.Set("certificate_name", cert.Name)
 	}
 
-	return diag.FromErr(err)
+	return nil
 }
 
 func resourceDigitalOceanCDNUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {