Update to Node.js 18 (#442)

digitalocean · Jul 28, 2023 · 4bf8e65 · 4bf8e65 · github-actions · Jul 28, 2023
1 parent 15deb4e
commit 4bf8e65
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 55 deletions.
diff --git a/.github/workflows/do-spaces-workflow.yml b/.github/workflows/do-spaces-workflow.yml
@@ -19,16 +19,6 @@ jobs:
           node-version-file: .nvmrc
           cache: npm
 
-      - name: Setup NPM
-        run: |
-          NPM_VERSION=$(jq -r .engines.npm package.json)
-          NPM_VERSION=${NPM_VERSION/\^/}
-          if [ "$(npm --version)" != "$NPM_VERSION" ]; then
-            npm install -g npm@$NPM_VERSION && npm --version
-          else
-            echo "NPM version is same as package.json engines.npm"
-          fi
-
       - name: Install dependencies
         run: npm ci
 

diff --git a/.github/workflows/gh-pages-workflow.yml b/.github/workflows/gh-pages-workflow.yml
@@ -26,16 +26,6 @@ jobs:
           node-version-file: .nvmrc
           cache: npm
 
-      - name: Setup NPM
-        run: |
-          NPM_VERSION=$(jq -r .engines.npm package.json)
-          NPM_VERSION=${NPM_VERSION/\^/}
-          if [ "$(npm --version)" != "$NPM_VERSION" ]; then
-            npm install -g npm@$NPM_VERSION && npm --version
-          else
-            echo "NPM version is same as package.json engines.npm"
-          fi
-
       - name: Install dependencies
         run: npm ci
 

diff --git a/.github/workflows/test-workflow.yml b/.github/workflows/test-workflow.yml
@@ -16,16 +16,6 @@ jobs:
           node-version-file: .nvmrc
           cache: npm
 
-      - name: Setup NPM
-        run: |
-          NPM_VERSION=$(jq -r .engines.npm package.json)
-          NPM_VERSION=${NPM_VERSION/\^/}
-          if [ "$(npm --version)" != "$NPM_VERSION" ]; then
-            npm install -g npm@$NPM_VERSION && npm --version
-          else
-            echo "NPM version is same as package.json engines.npm"
-          fi
-
       - name: Install dependencies
         run: npm ci
 
@@ -45,16 +35,6 @@ jobs:
           node-version-file: .nvmrc
           cache: npm
 
-      - name: Setup NPM
-        run: |
-          NPM_VERSION=$(jq -r .engines.npm package.json)
-          NPM_VERSION=${NPM_VERSION/\^/}
-          if [ "$(npm --version)" != "$NPM_VERSION" ]; then
-            npm install -g npm@$NPM_VERSION && npm --version
-          else
-            echo "NPM version is same as package.json engines.npm"
-          fi
-
       - name: Install dependencies
         run: npm ci
 
@@ -74,16 +54,6 @@ jobs:
           node-version-file: .nvmrc
           cache: npm
 
-      - name: Setup NPM
-        run: |
-          NPM_VERSION=$(jq -r .engines.npm package.json)
-          NPM_VERSION=${NPM_VERSION/\^/}
-          if [ "$(npm --version)" != "$NPM_VERSION" ]; then
-            npm install -g npm@$NPM_VERSION && npm --version
-          else
-            echo "NPM version is same as package.json engines.npm"
-          fi
-
       - name: Install dependencies
         run: npm ci
 

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v16.18.1
+v18.17.0
diff --git a/package.json b/package.json
@@ -4,10 +4,6 @@
   "description": "NGINX config generator on steroids",
   "private": true,
   "license": "MIT",
-  "engines": {
-    "node": "^16.17.1",
-    "npm": "^8.15.0"
-  },
   "main": "src/nginxconfig/mount.js",
   "type": "module",
   "scripts": {