Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx fusion auth stack #533

Merged
merged 2 commits into from
Aug 19, 2024
Merged

FIx fusion auth stack #533

merged 2 commits into from
Aug 19, 2024

Conversation

alexeigutium
Copy link
Contributor

BACKGROUND

  • FusionAuth is broken in DO marketplace

Changes

  • this PR updates it to the latest version and fix the elasticsearch configuration problem, it will fix the app installation process

Checklist

  • review the contributing doc with steps for both adding or updating your application (if applicable)

Reviewer: @marketplace-eng

Copy link

gitguardian bot commented Aug 19, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13467312 Triggered Generic Password 49adb4d stacks/fusionauth/deploy.sh View secret
13467312 Triggered Generic Password 49adb4d stacks/fusionauth/deploy.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@scott scott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alexeigutium alexeigutium merged commit 4428df7 into master Aug 19, 2024
1 check passed
@alexeigutium alexeigutium deleted the fix_fusionauth_stack branch August 19, 2024 16:08
Copy link

👋 @alexeigutium
If this is an EXISTING Marketplace app, now that the PR is merged, all new users of your app will get the current version. You should visit the Vendor Portal to make sure you update any version numbers, Description, or Getting Started information that are related to the merged PR.
If this is a BRAND NEW Marketplace app, before this app update can go live on the Marketplace, please update and submit your app from the Vendor Portal.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants