use uint64 for some big values that set to max by default

digitalocean · Sep 24, 2024 · 3b8d0fd · 3b8d0fd
1 parent 17766f7
commit 3b8d0fd
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 19 deletions.
diff --git a/databases.go b/databases.go
@@ -663,23 +663,23 @@ type MongoDBConfig struct {
 
 // KafkaConfig holds advanced configurations for Kafka database clusters.
 type KafkaConfig struct {
-	GroupInitialRebalanceDelayMs       *int   `json:"group_initial_rebalance_delay_ms,omitempty"`
-	GroupMinSessionTimeoutMs           *int   `json:"group_min_session_timeout_ms,omitempty"`
-	GroupMaxSessionTimeoutMs           *int   `json:"group_max_session_timeout_ms,omitempty"`
-	MessageMaxBytes                    *int   `json:"message_max_bytes,omitempty"`
-	LogCleanerDeleteRetentionMs        *int64 `json:"log_cleaner_delete_retention_ms,omitempty"`
-	LogCleanerMinCompactionLagMs       *int64 `json:"log_cleaner_min_compaction_lag_ms,omitempty"`
-	LogFlushIntervalMs                 *int64 `json:"log_flush_interval_ms,omitempty"`
-	LogIndexIntervalBytes              *int   `json:"log_index_interval_bytes,omitempty"`
-	LogMessageDownconversionEnable     *bool  `json:"log_message_downconversion_enable,omitempty"`
-	LogMessageTimestampDifferenceMaxMs *int64 `json:"log_message_timestamp_difference_max_ms,omitempty"`
-	LogPreallocate                     *bool  `json:"log_preallocate,omitempty"`
-	LogRetentionBytes                  *int64 `json:"log_retention_bytes,omitempty"`
-	LogRetentionHours                  *int   `json:"log_retention_hours,omitempty"`
-	LogRetentionMs                     *int64 `json:"log_retention_ms,omitempty"`
-	LogRollJitterMs                    *int64 `json:"log_roll_jitter_ms,omitempty"`
-	LogSegmentDeleteDelayMs            *int   `json:"log_segment_delete_delay_ms,omitempty"`
-	AutoCreateTopicsEnable             *bool  `json:"auto_create_topics_enable,omitempty"`
+	GroupInitialRebalanceDelayMs       *int    `json:"group_initial_rebalance_delay_ms,omitempty"`
+	GroupMinSessionTimeoutMs           *int    `json:"group_min_session_timeout_ms,omitempty"`
+	GroupMaxSessionTimeoutMs           *int    `json:"group_max_session_timeout_ms,omitempty"`
+	MessageMaxBytes                    *int    `json:"message_max_bytes,omitempty"`
+	LogCleanerDeleteRetentionMs        *int64  `json:"log_cleaner_delete_retention_ms,omitempty"`
+	LogCleanerMinCompactionLagMs       *int64  `json:"log_cleaner_min_compaction_lag_ms,omitempty"`
+	LogFlushIntervalMs                 *uint64 `json:"log_flush_interval_ms,omitempty"`
+	LogIndexIntervalBytes              *int    `json:"log_index_interval_bytes,omitempty"`
+	LogMessageDownconversionEnable     *bool   `json:"log_message_downconversion_enable,omitempty"`
+	LogMessageTimestampDifferenceMaxMs *uint64 `json:"log_message_timestamp_difference_max_ms,omitempty"`
+	LogPreallocate                     *bool   `json:"log_preallocate,omitempty"`
+	LogRetentionBytes                  *int64  `json:"log_retention_bytes,omitempty"`
+	LogRetentionHours                  *int    `json:"log_retention_hours,omitempty"`
+	LogRetentionMs                     *int64  `json:"log_retention_ms,omitempty"`
+	LogRollJitterMs                    *int64  `json:"log_roll_jitter_ms,omitempty"`
+	LogSegmentDeleteDelayMs            *int    `json:"log_segment_delete_delay_ms,omitempty"`
+	AutoCreateTopicsEnable             *bool   `json:"auto_create_topics_enable,omitempty"`
 }
 
 type databaseUserRoot struct {

diff --git a/databases_test.go b/databases_test.go
@@ -3101,10 +3101,10 @@ func TestDatabases_GetConfigKafka(t *testing.T) {
 			MessageMaxBytes:                    PtrTo(1048588),
 			LogCleanerDeleteRetentionMs:        PtrTo(int64(86400000)),
 			LogCleanerMinCompactionLagMs:       PtrTo(int64(0)),
-			LogFlushIntervalMs:                 PtrTo(int64(60000)),
+			LogFlushIntervalMs:                 PtrTo(uint64(60000)),
 			LogIndexIntervalBytes:              PtrTo(4096),
 			LogMessageDownconversionEnable:     PtrTo(true),
-			LogMessageTimestampDifferenceMaxMs: PtrTo(int64(120000)),
+			LogMessageTimestampDifferenceMaxMs: PtrTo(uint64(120000)),
 			LogPreallocate:                     PtrTo(false),
 			LogRetentionBytes:                  PtrTo(int64(-1)),
 			LogRetentionHours:                  PtrTo(168),