Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always follow link header if content-type is not json. #141

Closed
wants to merge 1 commit into from
Closed

Always follow link header if content-type is not json. #141

wants to merge 1 commit into from

Conversation

JulienPalard
Copy link

Trying myself at #129 (comment)

Fixes #128
Ref #129

Highly inspired from #129, but trying myself at it.

Master before and after this PR has the same set of failing tests:

FAILED (failures=5, errors=2, skipped=30)
OK (skipped=1)
OK (skipped=3)

The tests provided in #129 are passing, and:

print(
    json.dumps(
        jsonld.expand(
            {
                "@context": "http://schema.org/",
                "@type": "Person",
                "name": "Jane Doe",
                "jobTitle": "Professor",
                "telephone": "(425) 123-4567",
                "url": "http://www.janedoe.com",
            }
        ),
        indent=4,
    )
)

now passes too.

@JulienPalard
Copy link
Author

I'd like to add some tests to the test suite, but I don't understand how to do so. If someone can explain before merging I'd gladly do so.

meritasix added a commit to meritasix/pyld that referenced this pull request Feb 8, 2021
@JulienPalard JulienPalard closed this by deleting the head repository Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyld does not inspect Link headers
1 participant