Fix Daml3-script issue with LF1.15 #20236
Open
+278
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-williams-da
force-pushed
the
sw/fix-daml3-script-without-upgrades
branch
from
3b31753
to
2300e87
Compare
There was a problem hiding this comment.
This file was copied out of the daml-test-files, as the one used in Dev mode has GuardedExercise, which will not compile in 1.15
...italasset/daml/lf/engine/script/v2/ledgerinteraction/grpcLedgerClient/GrpcLedgerClient.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #20087, submissions on Daml3-script with LF1.15 would lead to a "Couldn't resolve package name" issue, as the LF1.15 commands were being given
#package-namefor their package-id.This PR fixes that issue, and migrates a daml3-script test suite over so we can catch these issues in future.
I've also added a small internal flag to daml sandbox, so I can more easily spin up non-upgrade sandboxes in future. I can remove this if we don't want it (See 5dc53de)