Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port from Canton: Use -Xsource:3-cross instead of -Xsource:3 #20125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Port from Canton: Use -Xsource:3-cross instead of -Xsource:3 #20125

wants to merge 1 commit into from

Conversation

carlpulley-da
Copy link
Contributor

@carlpulley-da carlpulley-da commented Oct 18, 2024 •
edited by yves-da
Loading

@carlpulley-da carlpulley-da requested review from a team, rgugliel-da and yves-da October 18, 2024 14:23
@carlpulley-da carlpulley-da marked this pull request as ready for review October 18, 2024 14:23
yves-da
yves-da approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@yves-da yves-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

But should this Scala compiler flag be limited to canton only 🤔

@yves-da yves-da changed the title Port of issue https://github.com/DACH-NY/canton/pull/21937 Port from Canton: 'Use -Xsource:3-cross instead of -Xsource:3 Oct 18, 2024
@yves-da yves-da changed the title Port from Canton: 'Use -Xsource:3-cross instead of -Xsource:3 Port from Canton: Use -Xsource:3-cross instead of -Xsource:3 Oct 18, 2024
@carlpulley-da
Copy link
Contributor Author

But should this Scala compiler flag be limited to canton only

I believe so: on the daml side we don't use the compiler flag -source:3 and so don't hit this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yves-da yves-da yves-da approved these changes

@rgugliel-da rgugliel-da rgugliel-da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlpulley-da @rgugliel-da @yves-da