chore: Configure to build with EAS [WIP] #739
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f4643be.
|
@achou11 I think we can re-visit this now, see my next-steps in the comment above. |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration for building with EAS Build and for building a custom dev client that allows mobile development without requiring Android Studio or XCode to be installed.
I was able to get EAS build working correctly. The infrastructure is slower than Cirrus CI, but faster than Github. The nice thing about it is it can also run locally
eas build --platform android --local, so we could run it on Cirrus CI if we wanted to. I like the idea of configuring the build process once and being able to run anywhere.I had limited success with the custom development client. I was able to build it locally, but it did not work when building with EAS build. I think this is because it required an upgrade to Android Gradle Plugin, and that seems to have stopped nodejs-mobile from building native modules. It was only working for me because the native modules were already built and cached in my build folder. It was nice to work with: After installing the dev client on my phone I was able to run
expo start --dev-clientand then work on Mapeo as if I was using expo. We just need to update the dev client whenever we change a native dep or change the backend.The latest React Native 0.65 release includes updates to Gradle and Android Gradle Plugin. It might be worth updating that first, ensuring everything works, and then rebasing this PR on that. We may need to update nodejs-mobile to 0.6.2 (we are running 0.6.1) but I want to avoid that because our tests show that sync has errors when running on Node v12.19.0 for some reason (see #500).
Next steps:
develop