fix: fix issues with BottomSheetModal implementation #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achou11
force-pushed
the
ac/bottom-sheet-modal-refactor
branch
from
c1a86df to
5b67805
Compare
ErikSin
reviewed
Feb 16, 2023
| @@ -51,7 +52,9 @@ const App = () => ( | |||
| <PermissionsProvider> | |||
| <AppLoading> | |||
| <AppProvider> | |||
| <AppContainerWrapper /> | |||
| <BottomSheetModalProvider> | |||
There was a problem hiding this comment.
Can you add a comment explaining why this is here.
|
Closes #1082 |
achou11
force-pushed
the
ac/bottom-sheet-modal-refactor
branch
from
5b67805 to
310401b
Compare
achou11
force-pushed
the
ac/bottom-sheet-modal-refactor
branch
from
310401b to
94d4eb0
Compare
achou11
force-pushed
the
ac/bottom-sheet-modal-refactor
branch
from
db02e2d to
5a350dd
Compare
|
@ErikSin any interest in revisiting this to get it merged for next release? |
This fixes the issue of the bottom sheet modal backdrop not overlaying the navigation header. Without this, the header is accessible even when the modal is open, which we don't want (e.g. header back button shouldn't be reachable). Uses suggestion provided in gorhom/react-native-bottom-sheet#1157
achou11
force-pushed
the
ac/bottom-sheet-modal-refactor
branch
from
5a350dd to
fa86384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of issues that are fixed:
The backdrop didn't overlap the native navigation header, which meant that interaction with that header was not blocked, allowing things like going back to a previous screen when the modal was opened. Now it overlaps the header and prevents interaction there, as desired.
Before:
After:
When on a screen that contains the
BottomSheetModal, the default disabled back behavior via Android's hardware back button was active even though the modal was closed. Now the disabled back behavior is disabled only when the modal is open