Skip to content

Commit

Permalink
fix: Allow publishing on Google Play Store by enabling 64-bit builds
Browse files Browse the repository at this point in the history
This makes the APKs much bigger, and increased build time. We can create app bundles instead and sign with the play store in the future to resolve this:

https://medium.com/@andriidrozdov/reactnative-and-android-64-bit-new-google-play-market-rules-what-to-do-584b067d6f1a
  • Loading branch information
gmaclennan committed Nov 5, 2019
1 parent 20038b7 commit 4cc4107
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ android {
versionCode 1
versionName "1.0"
ndk {
abiFilters "armeabi-v7a", "x86"
abiFilters "armeabi-v7a", "x86", "arm64-v8a", "x86_64"
}
// Detox integration
// testBuildType System.getProperty('testBuildType', 'debug') //this will later be used to control the test apk build type
Expand All @@ -157,7 +157,7 @@ android {
reset()
enable enableSeparateBuildPerCPUArchitecture
universalApk false // If true, also generate a universal APK
include "armeabi-v7a", "x86"
include "armeabi-v7a", "x86", "arm64-v8a", "x86_64"
}
}
signingConfigs {
Expand Down Expand Up @@ -207,7 +207,7 @@ android {
variant.outputs.each { output ->
// For each separate APK per architecture, set a unique version code as described here:
// https://developer.android.com/studio/build/configure-apk-splits.html
def versionCodes = ["armeabi-v7a":1, "x86":2]
def versionCodes = ["armeabi-v7a":1, "x86":2, "arm64-v8a": 3, "x86_64": 4]
def abi = output.getFilter(OutputFile.ABI)
if (abi != null) { // null for the universal-debug, universal-release variants
output.versionCodeOverride =
Expand Down

0 comments on commit 4cc4107

Please sign in to comment.