Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRACTS] DFCC loop assigns infererence with functions inlined #8490

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

qinheping
Copy link
Collaborator

@qinheping qinheping commented Oct 31, 2024

Current loop assigns inference of DFCC can only infer targets considering only instructions in the same function. However, variables may be written to in the call of another function from function call inside the loop. So in this PR, we infer loop assigns based on a copy of the function and inlining all calls in the copy.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 64.41718% with 58 lines in your changes missing coverage. Please review.

Project coverage is 78.75%. Comparing base (f2a7665) to head (45d7ad7).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ntracts/dynamic-frames/dfcc_infer_loop_assigns.cpp 68.31% 32 Missing ⚠️
src/goto-instrument/loop_utils.cpp 55.81% 19 Missing ⚠️
...trument/contracts/dynamic-frames/dfcc_cfg_info.cpp 63.15% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8490      +/-   ##
===========================================
- Coverage    78.88%   78.75%   -0.13%     
===========================================
  Files         1727     1727              
  Lines       198333   198768     +435     
  Branches     18475    18480       +5     
===========================================
+ Hits        156453   156549      +96     
- Misses       41880    42219     +339     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant