Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format_expr now prints bv-typed constants #8457

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

kroening
Copy link
Member

@kroening kroening commented Sep 16, 2024

This adds formatting for bv-type constants to format_expr. As the bv type does not have a numerical representation, the 0/1 bit pattern is printed, starting with the bit with the highest index.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.39%. Comparing base (5002f3b) to head (2ed72b0).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8457      +/-   ##
===========================================
+ Coverage    78.35%   78.39%   +0.03%     
===========================================
  Files         1726     1726              
  Lines       188695   188624      -71     
  Branches     18301    18265      -36     
===========================================
+ Hits        147851   147864      +13     
+ Misses       40844    40760      -84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This adds formatting for bv-type constants to format_expr.  As the bv type
does not have a numerical representation, the 0/1 bit pattern is printed,
starting with the bit with the highest index.
@kroening kroening marked this pull request as ready for review September 17, 2024 13:42
@kroening kroening merged commit 46c1b0f into develop Sep 17, 2024
41 checks passed
@kroening kroening deleted the format_expr_bv_constant branch September 17, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants