Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java_bytecode_parsert: construct with message handler #8140

Merged

Conversation

tautschnig
Copy link
Collaborator

This both avoids an object of static lifetime as well as it fixes the (transitive) use of the deprecated messaget() constructor.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This both avoids an object of static lifetime as well as it fixes the
(transitive) use of the deprecated messaget() constructor.
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (856c641) 79.08% compared to head (7f3eef2) 79.08%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8140   +/-   ##
========================================
  Coverage    79.08%   79.08%           
========================================
  Files         1695     1695           
  Lines       196514   196514           
========================================
+ Hits        155408   155412    +4     
+ Misses       41106    41102    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit 8182793 into diffblue:develop Dec 21, 2023
39 checks passed
@tautschnig tautschnig deleted the cleanup/java_bytecode_parsert branch December 21, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants