statement_list_parsert: construct with message handler #8138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #8138 +/- ##
===========================================
- Coverage 79.09% 79.09% -0.01%
===========================================
Files 1695 1696 +1
Lines 196589 196596 +7
===========================================
+ Hits 155493 155496 +3
- Misses 41096 41100 +4 ☔ View full report in Codecov by Sentry. |
tautschnig
force-pushed
the
cleanup/statement_list_parsert
branch
from
1ffaf6b
to
647ea51
Compare
tautschnig
force-pushed
the
cleanup/statement_list_parsert
branch
from
647ea51
to
cb1f557
Compare
|
Keeping as draft until reentrancy questions are settled in #8153. |
3 tasks
This both avoids an object of static lifetime as well as it fixes the (transitive) use of the deprecated messaget() constructor. Avoid global objects in the lexer (as side-effect making it reentrant) as initialisation is required. The parser continues to have global state, so guard against reentrant use.
tautschnig
force-pushed
the
cleanup/statement_list_parsert
branch
from
cb1f557
to
1434e97
Compare
|
Now uses the same style of guards as agreed for JSIL in #8153. |
peterschrammel
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This both avoids an object of static lifetime as well as it fixes the (transitive) use of the deprecated messaget() constructor.