Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSIL: create messaget with a message handler #8125

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

tautschnig
Copy link
Collaborator

Apply RAII and avoid a deprecated messaget constructor.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Apply RAII and avoid a deprecated messaget constructor.
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (92e3c0f) 79.08% compared to head (e13dfe4) 79.08%.

Files Patch % Lines
src/jsil/jsil_entry_point.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8125   +/-   ##
========================================
  Coverage    79.08%   79.08%           
========================================
  Files         1697     1697           
  Lines       196493   196492    -1     
========================================
+ Hits        155395   155398    +3     
+ Misses       41098    41094    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit bbf90cc into diffblue:develop Dec 19, 2023
38 of 39 checks passed
@tautschnig tautschnig deleted the cleanup/jsil-messaget branch December 19, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants