Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run again tests with new default checks #8106

Merged

Conversation

esteffin
Copy link
Contributor

@esteffin esteffin commented Dec 14, 2023

This is reverting changes currently in develop which were applying the --no-standard-checks across all CMakeLists.txt and makefiles in the regression folder while we were trying to stabilise the new standard check flags in #8093.

This should bring all relevant flags for test execution into the appropriate *.desc files to make it easier to see what flags a test run actually executes with.

@esteffin esteffin force-pushed the esteffin/fixing-tests-new-default-checks branch 3 times, most recently from 32cbc52 to 168468c Compare December 15, 2023 17:57
@NlightNFotis NlightNFotis changed the title [DO NOT REVIEW] [DO NOT MERGE] Run again tests with new default checks Run again tests with new default checks Dec 18, 2023
@esteffin esteffin force-pushed the esteffin/fixing-tests-new-default-checks branch 7 times, most recently from aeea845 to 58f05d9 Compare December 20, 2023 22:03
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8182793) 79.08% compared to head (77705eb) 79.09%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8106      +/-   ##
===========================================
+ Coverage    79.08%   79.09%   +0.01%     
===========================================
  Files         1695     1695              
  Lines       196514   196514              
===========================================
+ Hits        155412   155436      +24     
+ Misses       41102    41078      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteffin esteffin force-pushed the esteffin/fixing-tests-new-default-checks branch from 439e84c to 12ff897 Compare December 21, 2023 17:23
@esteffin esteffin marked this pull request as ready for review December 22, 2023 10:35
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the painstaking work to bring these all back. Merry Christmas!

@esteffin esteffin force-pushed the esteffin/fixing-tests-new-default-checks branch from 12ff897 to 77705eb Compare December 22, 2023 10:37
@esteffin esteffin merged commit 8fee19a into diffblue:develop Dec 22, 2023
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants