Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all uses of deprecated functions by non-deprecated ones [depends-on: #5621, #5587, #5599, #4050] #3800

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Replace all uses of deprecated functions by non-deprecated ones [depends-on: #5621, #5587, #5599, #4050] #3800

wants to merge 16 commits into from

Conversation

tautschnig
Copy link
Collaborator

This is currently in proof-of-concept stage with all changes in a single commit: I've tried to figure out what it would take to get rid of all the uses of deprecated functions. I will over time create individual commits and PRs that resolve one function at a time.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Jan 14, 2019
@martin-cs
Copy link
Collaborator

What, if any, reviewing do you want on this? It seems quite a few parts have already been split out and merged.

tautschnig added a commit that referenced this pull request Jan 22, 2019
@tautschnig
Merge pull request #3884 from tautschnig/deprecation-parametert
8300e2d 
Construct parametert in a non-deprecated way [blocks: #3800]
tautschnig added a commit that referenced this pull request Jan 23, 2019
@tautschnig
Merge pull request #3879 from tautschnig/deprecation-integer2unsigned
20f17ad 
Use numeric_cast_v<unsigned> instead to_ulong with incompatible types [blocks: #3800]
tautschnig added a commit that referenced this pull request Jan 23, 2019
@tautschnig
Merge pull request #3883 from tautschnig/deprecation-read_goto_binary
8af67d1 
Use non-deprecated variants of read_goto_binary [blocks: #3800]
tautschnig added a commit that referenced this pull request Jan 23, 2019
@tautschnig
Merge pull request #3885 from tautschnig/deprecation-code_function_callt
e2a5430 
Use non-trivial constructor of code_function_callt [blocks: #3800]
tautschnig added a commit that referenced this pull request Jan 24, 2019
@tautschnig
Merge pull request #3906 from tautschnig/deprecation-conjunction
3fe359e 
Use conjunction instead of piecewise construction of and_exprt [blocks: #3800]
tautschnig added a commit that referenced this pull request Jan 24, 2019
@tautschnig
Merge pull request #3903 from tautschnig/deprecation-complex_typet
3a7de29 
Construct complex_typet in a non-deprecated way [blocks: #3800]
tautschnig added a commit that referenced this pull request Jan 26, 2019
@tautschnig
Merge pull request #3940 from tautschnig/deprecation-nil_typet-unreac…
70b96ab 
…hable

Remove unreachable statement [blocks: #3800]
tautschnig added a commit that referenced this pull request Jan 26, 2019
@tautschnig
Merge pull request #3944 from tautschnig/deprecation-nil_typet-sizeof
85d61b5 
Replace use of deprecated nil_typet in c_sizeof_type_rec [blocks: #3800]
tautschnig added a commit that referenced this pull request Jan 26, 2019
@tautschnig
Merge pull request #3945 from tautschnig/deprecation-nil_typet-bitfield
3120f0f 
Replace use of deprecated nil_typet in c_bit_field_replacement_type [blocks: #3800]
tautschnig added a commit that referenced this pull request Jan 27, 2019
@tautschnig
Merge pull request #3935 from tautschnig/deprecation-ifthenelse
2db2eb2 
Avoid default constructing code_ifthenelset [blocks: #3800]
tautschnig added a commit that referenced this pull request Jan 27, 2019
@tautschnig
Merge pull request #3948 from tautschnig/deprecation-nil_typet-smt2
7f2ff2c 
smt2 id_map: Do not use nil_typet when we mean "optional" [blocks: #3800]
@tautschnig tautschnig reopened this May 4, 2023
@tautschnig tautschnig mentioned this pull request Nov 7, 2023
Open
23 tasks
thomasspriggs added a commit that referenced this pull request Dec 12, 2023
@thomasspriggs
Merge pull request #4050 from tautschnig/messaget-languaget
3bf78f7 
languaget is not a messaget [blocks: #3800]
@thomasspriggs
Copy link
Collaborator

@tautschnig Looks like this now needs rebasing.

@tautschnig
C++ front-end: configure C++11+ syntax without ansi_c_parser object
aa47f32 
There is no need to access the parser object when the same information
is available directly from `config`.
@tautschnig
Make ansi_c_internal_additions independent of the parser object
6f2fd34 
Thread through a Boolean flag rather than relying on the parser object
far away from the actual parser.
@tautschnig
Permit constructing parsert with a message handler
d2ca83b 
This is to provide a path to remove the long-deprecated messaget()
constructor. Uses of this new constructor will be added in separate
commits.
@tautschnig
xml_parsert: construct with message handler
eb4f6dc 
This both avoids an object of static lifetime as well as it fixes the
(transitive) use of the deprecated messaget() constructor.
@tautschnig
jsil_parsert: construct with message handler
28bae14 
This both avoids an object of static lifetime as well as it fixes the
(transitive) use of the deprecated messaget() constructor.
@tautschnig
json_parsert: construct with message handler
043b937 
This both avoids an object of static lifetime as well as it fixes the
(transitive) use of the deprecated messaget() constructor.
@tautschnig
statement_list_parsert: construct with message handler
462e66f 
This both avoids an object of static lifetime as well as it fixes the
(transitive) use of the deprecated messaget() constructor.
@tautschnig
assembler_parsert: construct with message handler
2446e6d 
This both avoids an object of static lifetime as well as it fixes the
(transitive) use of the deprecated messaget() constructor.
@tautschnig
java_bytecode_parsert: construct with message handler
6ba6910 
This both avoids an object of static lifetime as well as it fixes the
(transitive) use of the deprecated messaget() constructor.
@tautschnig
ansi_c_parsert: construct with message handler
3d6de5a 
This both avoids an object of static lifetime as well as it fixes the
(transitive) use of the deprecated messaget() constructor.
@tautschnig
cpp_parsert: construct with message handler
1ed3679 
This both avoids an object of static lifetime as well as it fixes the
(transitive) use of the deprecated messaget() constructor.
@tautschnig
Remove deprecated messaget() constructor
fc7b43e 
It is now no longer possible to construct a messaget object that is not
fully configured, i.e., lacks a message handler.
@tautschnig
Remove -Wno-deprecated-declarations from compiler options
458535e 
All uses of deprecated functions have been replaced.
@tautschnig
WIP: String solver deprecation cleanup
db11df7
@tautschnig
De-deprecated source_locationt methods
8a27a92
@tautschnig
WIP, create PRs
e23573d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj Awaiting requested review from allredj

@cesaro cesaro Awaiting requested review from cesaro

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@cristina-david cristina-david Awaiting requested review from cristina-david

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@NathanJPhillips NathanJPhillips Awaiting requested review from NathanJPhillips

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@romainbrenguier romainbrenguier Awaiting requested review from romainbrenguier

@smowton smowton Awaiting requested review from smowton

@thk123 thk123 Awaiting requested review from thk123

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue Awaiting requested review from hannes-steffenhagen-diffblue

@thomasspriggs thomasspriggs Awaiting requested review from thomasspriggs

@NlightNFotis NlightNFotis Awaiting requested review from NlightNFotis

@TGWDB TGWDB Awaiting requested review from TGWDB TGWDB is a code owner

@chris-ryder chris-ryder Awaiting requested review from chris-ryder

@remi-delmas-3000 remi-delmas-3000 Awaiting requested review from remi-delmas-3000 remi-delmas-3000 is a code owner

@feliperodri feliperodri Awaiting requested review from feliperodri feliperodri is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@tautschnig tautschnig

Labels
dependent - do not merge do not review work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tautschnig @martin-cs @allredj @TGWDB @thomasspriggs