Try to improve the first user experience with our examples #4238
+110
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
weiznich
commented
Sep 6, 2024
weiznich
commented
- Fix a minor issue in one of the sqlite migrations
- Always use bundled libs by default there, as that should "just work" on most platforms
- Minor fix to the crate level documentation to point to the bundled features for pq-sys and mysqlclient-sys as well
Mingun
reviewed
Sep 6, 2024
diesel/src/lib.rs
Outdated
| //! pq-sys = { version = "0.6", features = ["bundled"] } | ||
| //! openssl-sys = { version = "0.9.100", features = ["vendored"] } | ||
| //! ``` | ||
| //! - `mysql`: This feature enables the idesel mysql backend. This feature implies `mysql_backend`. |
There was a problem hiding this comment.
Misprint
Suggested change
| //! - `mysql`: This feature enables the idesel mysql backend. This feature implies `mysql_backend`. | |
| //! - `mysql`: This feature enables the diesel mysql backend. This feature implies `mysql_backend`. |
weiznich
force-pushed
the
doc/fixes
branch
3 times, most recently
from
b645264
to
e91a02b
Compare
* Fix a minor issue in one of the sqlite migrations * Always use bundled libs by default there, as that should "just work" on most platforms * Minor fix to the crate level documentation to point to the bundled features for pq-sys and mysqlclient-sys as well
weiznich
force-pushed
the
doc/fixes
branch
19 times, most recently
from
ef85946
to
6740225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.