Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement array_upper #4219

Merged
merged 1 commit into from
Aug 30, 2024
Merged

implement array_upper #4219

merged 1 commit into from
Aug 30, 2024

Conversation

gushul
Copy link
Contributor

@gushul gushul commented Aug 30, 2024

added support for array_upper for postgres under #4153

@weiznich weiznich requested a review from a team August 30, 2024 15:33
guissalustiano
guissalustiano approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@guissalustiano guissalustiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for open the PR!

The changes looks good to me

@gushul gushul changed the title WIP implement array_upper implement array_upper Aug 30, 2024
wowinter13
wowinter13 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@wowinter13 wowinter13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiznich weiznich added this pull request to the merge queue Aug 30, 2024
Merged via the queue into diesel-rs:master with commit 08911c8 Aug 30, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wowinter13 wowinter13 wowinter13 approved these changes

@guissalustiano guissalustiano guissalustiano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gushul @wowinter13 @guissalustiano @weiznich